AIP-84 Fix default ordering when directly using SortParam #44393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Nov 26, 2024
jason810496
added a commit
to jason810496/airflow
that referenced
this pull request
Nov 26, 2024
uranusjr
reviewed
Nov 26, 2024
|
Merged, @uranusjr feel free to rebase and report back if the issue persists. |
pierrejeambrun
deleted the
aip-84-fix-default-ordering-when-directly-using-sort-param
branch
|
nice! |
pierrejeambrun
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Refactor get_connections * Allow Column type for `to_replace` parameter * Refactor get_dags * Refactor get_import_errors * Refactor SortParam, get_dag_runs * Fix default ordering when directly using SortParam - related: #44393 * Fix get_list_dag_runs_batch
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
* Refactor get_connections * Allow Column type for `to_replace` parameter * Refactor get_dags * Refactor get_import_errors * Refactor SortParam, get_dag_runs * Fix default ordering when directly using SortParam - related: apache#44393 * Fix get_list_dag_runs_batch
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Refactor get_connections * Allow Column type for `to_replace` parameter * Refactor get_dags * Refactor get_import_errors * Refactor SortParam, get_dag_runs * Fix default ordering when directly using SortParam - related: apache#44393 * Fix get_list_dag_runs_batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the flakiness observed in main.
When no order is specified (i.e None), this should use the primary key as the default sorting. (Exactly what we do to fill the query parameter default value, but in some cases we use the SortParam outside of the FastAPI dependency system, bypassing the
dynamic_dependsfunction).